From 11a8cbc1e57a7646a43f11de63a95b036a7fc20f Mon Sep 17 00:00:00 2001
From: Kevin Wan <wanjunfeng@gmail.com>
Date: Fri, 6 Oct 2023 23:41:09 +0800
Subject: [PATCH] chore: rename noOpBreaker to nopBreaker (#3602)

---
 core/breaker/breakers.go        |  2 +-
 core/breaker/nopbreaker.go      | 22 +++++++++++-----------
 core/breaker/nopbreaker_test.go |  4 ++--
 3 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/core/breaker/breakers.go b/core/breaker/breakers.go
index 4adf189a..be55d55a 100644
--- a/core/breaker/breakers.go
+++ b/core/breaker/breakers.go
@@ -59,7 +59,7 @@ func GetBreaker(name string) Breaker {
 // NoBreakerFor disables the circuit breaker for the given name.
 func NoBreakerFor(name string) {
 	lock.Lock()
-	breakers[name] = newNoOpBreaker()
+	breakers[name] = newNopBreaker()
 	lock.Unlock()
 }
 
diff --git a/core/breaker/nopbreaker.go b/core/breaker/nopbreaker.go
index 2cf0f716..a1b2e7cc 100644
--- a/core/breaker/nopbreaker.go
+++ b/core/breaker/nopbreaker.go
@@ -1,34 +1,34 @@
 package breaker
 
-const noOpBreakerName = "nopBreaker"
+const nopBreakerName = "nopBreaker"
 
-type noOpBreaker struct{}
+type nopBreaker struct{}
 
-func newNoOpBreaker() Breaker {
-	return noOpBreaker{}
+func newNopBreaker() Breaker {
+	return nopBreaker{}
 }
 
-func (b noOpBreaker) Name() string {
-	return noOpBreakerName
+func (b nopBreaker) Name() string {
+	return nopBreakerName
 }
 
-func (b noOpBreaker) Allow() (Promise, error) {
+func (b nopBreaker) Allow() (Promise, error) {
 	return nopPromise{}, nil
 }
 
-func (b noOpBreaker) Do(req func() error) error {
+func (b nopBreaker) Do(req func() error) error {
 	return req()
 }
 
-func (b noOpBreaker) DoWithAcceptable(req func() error, _ Acceptable) error {
+func (b nopBreaker) DoWithAcceptable(req func() error, _ Acceptable) error {
 	return req()
 }
 
-func (b noOpBreaker) DoWithFallback(req func() error, _ func(err error) error) error {
+func (b nopBreaker) DoWithFallback(req func() error, _ func(err error) error) error {
 	return req()
 }
 
-func (b noOpBreaker) DoWithFallbackAcceptable(req func() error, _ func(err error) error,
+func (b nopBreaker) DoWithFallbackAcceptable(req func() error, _ func(err error) error,
 	_ Acceptable) error {
 	return req()
 }
diff --git a/core/breaker/nopbreaker_test.go b/core/breaker/nopbreaker_test.go
index ecca1806..1756aa2a 100644
--- a/core/breaker/nopbreaker_test.go
+++ b/core/breaker/nopbreaker_test.go
@@ -8,8 +8,8 @@ import (
 )
 
 func TestNopBreaker(t *testing.T) {
-	b := newNoOpBreaker()
-	assert.Equal(t, noOpBreakerName, b.Name())
+	b := newNopBreaker()
+	assert.Equal(t, nopBreakerName, b.Name())
 	p, err := b.Allow()
 	assert.Nil(t, err)
 	p.Accept()