add more tests

core/breaker/breakers.go

@@ -47,6 +47,7 @@ func GetBreaker(name string) Breaker {
 		breakers[name] = b
 	}
 	lock.Unlock()
+
 	return b
 }
 

core/codec/dh_test.go

@@ -73,6 +73,9 @@ func TestDiffieHellmanMiddleManAttack(t *testing.T) {
 }
 
 func TestKeyBytes(t *testing.T) {
+	var empty DhKey
+	assert.Equal(t, 0, len(empty.Bytes()))
+
 	key, err := GenerateKey()
 	assert.Nil(t, err)
 	assert.True(t, len(key.Bytes()) > 0)

core/conf/config_test.go

@@ -32,8 +32,7 @@ func TestConfigJson(t *testing.T) {
 				A string `json:"a"`
 				B int    `json:"b"`
 			}
-			err = LoadConfig(tmpfile, &val)
+			MustLoad(tmpfile, &val)
-			assert.Nil(t, err)
 			assert.Equal(t, "foo", val.A)
 			assert.Equal(t, 1, val.B)
 		})

core/conf/properties.go

@@ -30,12 +30,12 @@ type mapBasedProperties struct {
 	lock       sync.RWMutex
 }
 
-// Loads the properties into a properties configuration instance. May return the
+// Loads the properties into a properties configuration instance.
-// configuration itself along with an error that indicates if there was a problem loading the configuration.
+// Returns an error that indicates if there was a problem loading the configuration.
 func LoadProperties(filename string) (Properties, error) {
 	lines, err := iox.ReadTextLines(filename, iox.WithoutBlank(), iox.OmitWithPrefix("#"))
 	if err != nil {
-		return nil, nil
+		return nil, err
 	}
 
 	raw := make(map[string]string)

core/conf/properties_test.go

@@ -41,3 +41,8 @@ func TestSetInt(t *testing.T) {
 	props.SetInt(key, value)
 	assert.Equal(t, value, props.GetInt(key))
 }
+
+func TestLoadBadFile(t *testing.T) {
+	_, err := LoadProperties("nosuchfile")
+	assert.NotNil(t, err)
+}