Fix zrpc code generation error with --remote (#1739)
Co-authored-by: anqiansong <anqiansong@bytedance.com>
This commit is contained in:
@@ -118,13 +118,18 @@ func removeGoctlFlag(args []string) []string {
|
|||||||
for step < len(args) {
|
for step < len(args) {
|
||||||
arg := args[step]
|
arg := args[step]
|
||||||
switch {
|
switch {
|
||||||
case arg == "--style", arg == "--home", arg == "--zrpc_out", arg == "--verbose", arg == "-v":
|
case arg == "--style", arg == "--home",
|
||||||
|
arg == "--zrpc_out", arg == "--verbose",
|
||||||
|
arg == "-v", arg == "--remote",
|
||||||
|
arg == "--branch":
|
||||||
step += 2
|
step += 2
|
||||||
continue
|
continue
|
||||||
case strings.HasPrefix(arg, "--style="),
|
case strings.HasPrefix(arg, "--style="),
|
||||||
strings.HasPrefix(arg, "--home="),
|
strings.HasPrefix(arg, "--home="),
|
||||||
strings.HasPrefix(arg, "--verbose="),
|
strings.HasPrefix(arg, "--verbose="),
|
||||||
strings.HasPrefix(arg, "-v="),
|
strings.HasPrefix(arg, "-v="),
|
||||||
|
strings.HasPrefix(arg, "--remote="),
|
||||||
|
strings.HasPrefix(arg, "--branch="),
|
||||||
strings.HasPrefix(arg, "--zrpc_out="):
|
strings.HasPrefix(arg, "--zrpc_out="):
|
||||||
step += 1
|
step += 1
|
||||||
continue
|
continue
|
||||||
|
|||||||
@@ -83,6 +83,14 @@ func Test_RemoveGoctlFlag(t *testing.T) {
|
|||||||
source: strings.Fields(`protoc --go_opt=. --go-grpc_out=. --zrpc_out=. foo.proto`),
|
source: strings.Fields(`protoc --go_opt=. --go-grpc_out=. --zrpc_out=. foo.proto`),
|
||||||
expected: "protoc --go_opt=. --go-grpc_out=. foo.proto",
|
expected: "protoc --go_opt=. --go-grpc_out=. foo.proto",
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
source: strings.Fields(`protoc --go_opt=. --go-grpc_out=. --zrpc_out=. --remote=foo --branch=bar foo.proto`),
|
||||||
|
expected: "protoc --go_opt=. --go-grpc_out=. foo.proto",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
source: strings.Fields(`protoc --go_opt=. --go-grpc_out=. --zrpc_out=. --remote foo --branch bar foo.proto`),
|
||||||
|
expected: "protoc --go_opt=. --go-grpc_out=. foo.proto",
|
||||||
|
},
|
||||||
}
|
}
|
||||||
for _, e := range testData {
|
for _, e := range testData {
|
||||||
cmd := strings.Join(removeGoctlFlag(e.source), " ")
|
cmd := strings.Join(removeGoctlFlag(e.source), " ")
|
||||||
|
|||||||
Reference in New Issue
Block a user