zeromicro/go-zero
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: fx/fn.Head func will forever block when n is less than 1 (#128)

Browse Source 
* fix fx/Stream Head func will forever block when n is less than 1

* update test case

* update test case
This commit is contained in:
codingfanlt
2020-10-15 14:10:37 +08:00
committed by GitHub
parent c824e9e118
commit 901fadb5d3
2 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
core/fx/fn.go
View File

@@ -159,6 +159,9 @@ func (p Stream) Group(fn KeyFunc) Stream {
} }
func (p Stream) Head(n int64) Stream { func (p Stream) Head(n int64) Stream {
if n < 1 {
panic("n must be greater than 0")
}
source := make(chan interface{}) source := make(chan interface{})
go func() { go func() {

8
core/fx/fn_test.go
View File

@@ -169,6 +169,14 @@ func TestHead(t *testing.T) {
assert.Equal(t, 3, result) assert.Equal(t, 3, result)
} }
func TestHeadZero(t *testing.T) {
assert.Panics(t, func() {
Just(1, 2, 3, 4).Head(0).Reduce(func(pipe <-chan interface{}) (interface{}, error) {
return nil, nil
})
})
}
func TestHeadMore(t *testing.T) { func TestHeadMore(t *testing.T) {
var result int var result int
Just(1, 2, 3, 4).Head(6).Reduce(func(pipe <-chan interface{}) (interface{}, error) { Just(1, 2, 3, 4).Head(6).Reduce(func(pipe <-chan interface{}) (interface{}, error) {