avoid goroutine leak after timeout (#575)

This commit is contained in:
Kevin Wan
2021-03-21 16:54:34 +08:00
committed by GitHub
parent c0db8d017d
commit 9e6c2ba2c0
3 changed files with 5 additions and 4 deletions

View File

@@ -26,7 +26,8 @@ func DoWithTimeout(fn func() error, timeout time.Duration, opts ...DoOption) err
ctx, cancel := contextx.ShrinkDeadline(parentCtx, timeout)
defer cancel()
done := make(chan error)
// create channel with buffer size 1 to avoid goroutine leak
done := make(chan error, 1)
panicChan := make(chan interface{}, 1)
go func() {
defer func() {
@@ -35,7 +36,6 @@ func DoWithTimeout(fn func() error, timeout time.Duration, opts ...DoOption) err
}
}()
done <- fn()
close(done)
}()
select {