add more tests (#1113)

2021-10-04 14:14:25 +08:00
parent 2d42c8fa00
commit 9f5bfa0088
2 changed files with 126 additions and 8 deletions
--- a/zrpc/internal/clientinterceptors/tracinginterceptor.go
+++ b/zrpc/internal/clientinterceptors/tracinginterceptor.go
@@ -67,10 +67,10 @@ func StreamTracingInterceptor(ctx context.Context, desc *grpc.StreamDesc, cc *gr
 			s, ok := status.FromError(err)
 			if ok {
 				span.SetStatus(codes.Error, s.Message())
+				span.SetAttributes(ztrace.StatusCodeAttr(s.Code()))
 			} else {
 				span.SetStatus(codes.Error, err.Error())
 			}
-			span.SetAttributes(ztrace.StatusCodeAttr(s.Code()))
 		} else {
 			span.SetAttributes(ztrace.StatusCodeAttr(gcodes.OK))
 		}