feat: more meaningful error messages, close body on httpc requests (#2238)

* feat: more meaningful error messages, close body on httpc requests

* fix: test failure
This commit is contained in:
Kevin Wan
2022-08-07 16:09:54 +08:00
committed by GitHub
parent c1c7584de1
commit a987512c7b
5 changed files with 26 additions and 5 deletions

View File

@@ -25,6 +25,8 @@ func ParseHeaders(resp *http.Response, val interface{}) error {
// ParseJsonBody parses the response body, which should be in json content type.
func ParseJsonBody(resp *http.Response, val interface{}) error {
defer resp.Body.Close()
if withJsonBody(resp) {
return mapping.UnmarshalJsonReader(resp.Body, val)
}