fix golint issues in core/stat (#515)

* change to use ServiceGroup to make it more clear

* fix golint issues in core/stat
This commit is contained in:
Kevin Wan
2021-02-24 15:13:56 +08:00
committed by GitHub
parent 56ad4776d4
commit acdaee0fb6
9 changed files with 53 additions and 23 deletions

View File

@@ -25,29 +25,29 @@ type (
Stopper
}
// A Group is a group of services.
Group struct {
// A ServiceGroup is a group of services.
ServiceGroup struct {
services []Service
stopOnce func()
}
)
// NewGroup returns a Group.
func NewGroup() *Group {
sg := new(Group)
// NewServiceGroup returns a ServiceGroup.
func NewServiceGroup() *ServiceGroup {
sg := new(ServiceGroup)
sg.stopOnce = syncx.Once(sg.doStop)
return sg
}
// Add adds service into sg.
func (sg *Group) Add(service Service) {
func (sg *ServiceGroup) Add(service Service) {
sg.services = append(sg.services, service)
}
// Start starts the Group.
// Start starts the ServiceGroup.
// There should not be any logic code after calling this method, because this method is a blocking one.
// Also, quitting this method will close the logx output.
func (sg *Group) Start() {
func (sg *ServiceGroup) Start() {
proc.AddShutdownListener(func() {
log.Println("Shutting down...")
sg.stopOnce()
@@ -56,12 +56,12 @@ func (sg *Group) Start() {
sg.doStart()
}
// Stop stops the Group.
func (sg *Group) Stop() {
// Stop stops the ServiceGroup.
func (sg *ServiceGroup) Stop() {
sg.stopOnce()
}
func (sg *Group) doStart() {
func (sg *ServiceGroup) doStart() {
routineGroup := threading.NewRoutineGroup()
for i := range sg.services {
@@ -74,7 +74,7 @@ func (sg *Group) doStart() {
routineGroup.Wait()
}
func (sg *Group) doStop() {
func (sg *ServiceGroup) doStop() {
for _, service := range sg.services {
service.Stop()
}

View File

@@ -41,7 +41,7 @@ func TestServiceGroup(t *testing.T) {
multipliers := []int{2, 3, 5, 7}
want := 1
group := NewGroup()
group := NewServiceGroup()
for _, multiplier := range multipliers {
want *= multiplier
service := newMockedService(multiplier)
@@ -68,7 +68,7 @@ func TestServiceGroup_WithStart(t *testing.T) {
var wait sync.WaitGroup
var lock sync.Mutex
wait.Add(len(multipliers))
group := NewGroup()
group := NewServiceGroup()
for _, multiplier := range multipliers {
var mul = multiplier
group.Add(WithStart(func() {
@@ -95,7 +95,7 @@ func TestServiceGroup_WithStarter(t *testing.T) {
var wait sync.WaitGroup
var lock sync.Mutex
wait.Add(len(multipliers))
group := NewGroup()
group := NewServiceGroup()
for _, multiplier := range multipliers {
var mul = multiplier
group.Add(WithStarter(mockedStarter{