refactor: simplify stringx.Replacer, and avoid potential infinite loops (#2877)
* simplify replace * backup * refactor: simplify stringx.Replacer * chore: add comments and const * chore: add more tests * chore: rename variable
This commit is contained in:
Kevin Wan
GitHub
@@ -6,15 +6,6 @@ import (
|
||||
"github.com/stretchr/testify/assert"
|
||||
)
|
||||
|
||||
func TestLongestMatchGuardedCondition(t *testing.T) {
|
||||
n := new(node)
|
||||
n.end = true
|
||||
uselessLen, matchLen, jump := n.longestMatch([]rune(""), nil)
|
||||
assert.Equal(t, 0, uselessLen)
|
||||
assert.Nil(t, jump)
|
||||
assert.Equal(t, 0, matchLen)
|
||||
}
|
||||
|
||||
func TestFuzzNodeCase1(t *testing.T) {
|
||||
keywords := []string{
|
||||
"cs8Zh",
|
||||
@@ -202,228 +193,3 @@ func BenchmarkNodeFind(b *testing.B) {
|
||||
trie.find([]rune("日本AV演员兼电视、电影演员。无名氏AV女优是xx出道, 日本AV女优们最精彩的表演是AV演员色情表演"))
|
||||
}
|
||||
}
|
||||
|
||||
func TestNode_longestMatchCase0(t *testing.T) {
|
||||
// match the longest word
|
||||
keywords := []string{
|
||||
"a",
|
||||
"ab",
|
||||
"abc",
|
||||
"abcd",
|
||||
}
|
||||
trie := new(node)
|
||||
for _, keyword := range keywords {
|
||||
trie.add(keyword)
|
||||
}
|
||||
trie.build()
|
||||
|
||||
uselessLen, matchLen, jump := trie.longestMatch([]rune("abcef"), nil)
|
||||
assert.Equal(t, 0, uselessLen)
|
||||
assert.Equal(t, 3, matchLen)
|
||||
assert.Nil(t, jump)
|
||||
}
|
||||
|
||||
func TestNode_longestMatchCase1(t *testing.T) {
|
||||
keywords := []string{
|
||||
"abcde",
|
||||
"bcde",
|
||||
"cde",
|
||||
"de",
|
||||
|
||||
"b",
|
||||
"bc",
|
||||
}
|
||||
trie := new(node)
|
||||
for _, keyword := range keywords {
|
||||
trie.add(keyword)
|
||||
}
|
||||
trie.build()
|
||||
|
||||
uselessLen, matchLen, jump := trie.longestMatch([]rune("abcdf"), nil)
|
||||
assert.Equal(t, 1, uselessLen)
|
||||
assert.Equal(t, 2, matchLen)
|
||||
assert.Nil(t, jump)
|
||||
}
|
||||
|
||||
func TestNode_longestMatchCase2(t *testing.T) {
|
||||
keywords := []string{
|
||||
"abcde",
|
||||
"bcde",
|
||||
"cde",
|
||||
"de",
|
||||
|
||||
"c",
|
||||
"cd",
|
||||
}
|
||||
trie := new(node)
|
||||
for _, keyword := range keywords {
|
||||
trie.add(keyword)
|
||||
}
|
||||
trie.build()
|
||||
|
||||
uselessLen, matchLen, jump := trie.longestMatch([]rune("abcdf"), nil)
|
||||
assert.Equal(t, 2, uselessLen)
|
||||
assert.Equal(t, 2, matchLen)
|
||||
assert.Nil(t, jump)
|
||||
}
|
||||
|
||||
func TestNode_longestMatchCase3(t *testing.T) {
|
||||
keywords := []string{
|
||||
"abcde",
|
||||
"bcde",
|
||||
"cde",
|
||||
"de",
|
||||
|
||||
"b",
|
||||
"bc",
|
||||
"c",
|
||||
"cd",
|
||||
}
|
||||
trie := new(node)
|
||||
for _, keyword := range keywords {
|
||||
trie.add(keyword)
|
||||
}
|
||||
trie.build()
|
||||
|
||||
uselessLen, matchLen, jump := trie.longestMatch([]rune("abcdf"), nil)
|
||||
assert.Equal(t, 1, uselessLen)
|
||||
assert.Equal(t, 2, matchLen)
|
||||
assert.Nil(t, jump)
|
||||
}
|
||||
|
||||
func TestNode_longestMatchCase4(t *testing.T) {
|
||||
keywords := []string{
|
||||
"abcde",
|
||||
"bcdf",
|
||||
"bcd",
|
||||
}
|
||||
trie := new(node)
|
||||
for _, keyword := range keywords {
|
||||
trie.add(keyword)
|
||||
}
|
||||
trie.build()
|
||||
|
||||
uselessLen, matchLen, paths := trie.longestMatch([]rune("abcdf"), nil)
|
||||
assert.Equal(t, 1, uselessLen)
|
||||
assert.Equal(t, 0, matchLen)
|
||||
assert.Equal(t, 4, len(paths))
|
||||
}
|
||||
|
||||
func TestNode_longestMatchCase5(t *testing.T) {
|
||||
keywords := []string{
|
||||
"abcdef",
|
||||
"bcde",
|
||||
}
|
||||
trie := new(node)
|
||||
for _, keyword := range keywords {
|
||||
trie.add(keyword)
|
||||
}
|
||||
trie.build()
|
||||
|
||||
uselessLen, matchLen, paths := trie.longestMatch([]rune("abcde"), nil)
|
||||
assert.Equal(t, 1, uselessLen)
|
||||
assert.Equal(t, 4, matchLen)
|
||||
assert.Nil(t, paths)
|
||||
}
|
||||
|
||||
func TestNode_longestMatchCase6(t *testing.T) {
|
||||
keywords := []string{
|
||||
"abcde",
|
||||
"bc",
|
||||
"d",
|
||||
}
|
||||
trie := new(node)
|
||||
for _, keyword := range keywords {
|
||||
trie.add(keyword)
|
||||
}
|
||||
trie.build()
|
||||
|
||||
uselessLen, matchLen, jump := trie.longestMatch([]rune("abcd"), nil)
|
||||
assert.Equal(t, 1, uselessLen)
|
||||
assert.Equal(t, 2, matchLen)
|
||||
assert.Nil(t, jump)
|
||||
}
|
||||
|
||||
func TestNode_longestMatchCase7(t *testing.T) {
|
||||
keywords := []string{
|
||||
"abcdeg",
|
||||
"cdef",
|
||||
"bcde",
|
||||
}
|
||||
trie := new(node)
|
||||
for _, keyword := range keywords {
|
||||
trie.add(keyword)
|
||||
}
|
||||
trie.build()
|
||||
|
||||
word := []rune("abcdef")
|
||||
uselessLen, matchLen, paths := trie.longestMatch(word, nil)
|
||||
assert.Equal(t, 1, uselessLen)
|
||||
assert.Equal(t, 4, matchLen)
|
||||
assert.Nil(t, paths)
|
||||
uselessLen, matchLen, paths = trie.longestMatch(word[uselessLen+matchLen:], paths)
|
||||
assert.Equal(t, 1, uselessLen)
|
||||
assert.Equal(t, 0, matchLen)
|
||||
assert.Nil(t, paths)
|
||||
}
|
||||
|
||||
func TestNode_longestMatchCase8(t *testing.T) {
|
||||
keywords := []string{
|
||||
"abcdeg",
|
||||
"cdef",
|
||||
"cde",
|
||||
}
|
||||
trie := new(node)
|
||||
for _, keyword := range keywords {
|
||||
trie.add(keyword)
|
||||
}
|
||||
trie.build()
|
||||
|
||||
word := []rune("abcdef")
|
||||
uselessLen, matchLen, paths := trie.longestMatch(word, nil)
|
||||
assert.Equal(t, 2, uselessLen)
|
||||
assert.Equal(t, 0, matchLen)
|
||||
assert.NotNil(t, paths)
|
||||
}
|
||||
|
||||
func TestNode_longestMatchCase9(t *testing.T) {
|
||||
keywords := []string{
|
||||
"abcdeg",
|
||||
"cdef",
|
||||
"cde",
|
||||
"cd",
|
||||
}
|
||||
trie := new(node)
|
||||
for _, keyword := range keywords {
|
||||
trie.add(keyword)
|
||||
}
|
||||
trie.build()
|
||||
|
||||
word := []rune("abcde")
|
||||
uselessLen, matchLen, paths := trie.longestMatch(word, nil)
|
||||
assert.Equal(t, 2, uselessLen)
|
||||
assert.Equal(t, 3, matchLen)
|
||||
assert.Nil(t, paths)
|
||||
}
|
||||
|
||||
func TestNode_jump(t *testing.T) {
|
||||
keywords := []string{
|
||||
"de",
|
||||
"fe",
|
||||
}
|
||||
trie := new(node)
|
||||
for _, keyword := range keywords {
|
||||
trie.add(keyword)
|
||||
}
|
||||
trie.build()
|
||||
target := []rune("dfe")
|
||||
|
||||
uselessLen, matchLen, paths := trie.longestMatch(target, nil)
|
||||
assert.Equal(t, 1, uselessLen)
|
||||
assert.Equal(t, 0, matchLen)
|
||||
assert.NotNil(t, paths)
|
||||
uselessLen, matchLen, paths = paths[len(paths)-1].longestMatch(target[uselessLen+matchLen:], paths)
|
||||
assert.Equal(t, 0, uselessLen)
|
||||
assert.Equal(t, 2, matchLen)
|
||||
assert.Nil(t, paths)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user