From ceab56442987e6ec61707faa276ba360aca90fa9 Mon Sep 17 00:00:00 2001
From: Kevin Wan <wanjunfeng@gmail.com>
Date: Tue, 24 Jan 2023 12:03:05 +0800
Subject: [PATCH] chore: add more tests (#2814)

---
 zrpc/internal/rpcpubserver_test.go | 16 ++++++++++++++++
 zrpc/internal/rpcserver_test.go    |  4 ++--
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/zrpc/internal/rpcpubserver_test.go b/zrpc/internal/rpcpubserver_test.go
index 93ce2227..e7e99dc5 100644
--- a/zrpc/internal/rpcpubserver_test.go
+++ b/zrpc/internal/rpcpubserver_test.go
@@ -4,9 +4,21 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/zeromicro/go-zero/core/discov"
 	"github.com/zeromicro/go-zero/core/netx"
 )
 
+func TestNewRpcPubServer(t *testing.T) {
+	s, err := NewRpcPubServer(discov.EtcdConf{
+		User: "user",
+		Pass: "pass",
+	}, "", ServerMiddlewaresConf{})
+	assert.NoError(t, err)
+	assert.NotPanics(t, func() {
+		s.Start(nil)
+	})
+}
+
 func TestFigureOutListenOn(t *testing.T) {
 	tests := []struct {
 		input  string
@@ -24,6 +36,10 @@ func TestFigureOutListenOn(t *testing.T) {
 			input:  ":8080",
 			expect: netx.InternalIp() + ":8080",
 		},
+		{
+			input:  "",
+			expect: netx.InternalIp(),
+		},
 	}
 
 	for _, test := range tests {
diff --git a/zrpc/internal/rpcserver_test.go b/zrpc/internal/rpcserver_test.go
index c1bab676..6de18073 100644
--- a/zrpc/internal/rpcserver_test.go
+++ b/zrpc/internal/rpcserver_test.go
@@ -18,7 +18,7 @@ func TestRpcServer(t *testing.T) {
 		Stat:       true,
 		Prometheus: true,
 		Breaker:    true,
-	}, WithMetrics(metrics))
+	}, WithMetrics(metrics), WithRpcHealth(true))
 	server.SetName("mock")
 	var wg sync.WaitGroup
 	var grpcServer *grpc.Server
@@ -48,7 +48,7 @@ func TestRpcServer_WithBadAddress(t *testing.T) {
 		Stat:       true,
 		Prometheus: true,
 		Breaker:    true,
-	})
+	}, WithRpcHealth(true))
 	server.SetName("mock")
 	err := server.Start(func(server *grpc.Server) {
 		mock.RegisterDepositServiceServer(server, new(mock.DepositServer))