zeromicro/go-zero
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: #2700, timeout not enough for writing responses (#2738)

Browse Source 
* fix: #2700, timeout not enough for writing responses

* fix: test fail

* chore: add comments
This commit is contained in:
Kevin Wan
2023-01-02 13:51:15 +08:00
committed by GitHub
parent 3e9d0161bc
commit dd294e8cd6
4 changed files with 27 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
rest/engine.go
View File

@@ -287,10 +287,9 @@ func (ng *engine) withTimeout() internal.StartOption {
// without this timeout setting, the server will time out and respond 503 Service Unavailable,
// which triggers the circuit breaker.
svr.ReadTimeout = 4 * time.Duration(timeout) * time.Millisecond / 5
// factor 0.9, to avoid clients not reading the response
// without this timeout setting, the server will time out and respond 503 Service Unavailable,
// which triggers the circuit breaker.
svr.WriteTimeout = 9 * time.Duration(timeout) * time.Millisecond / 10
// factor 1.1, to avoid servers don't have enough time to write responses.
// setting the factor less than 1.0 may lead clients not receiving the responses.
svr.WriteTimeout = 11 * time.Duration(timeout) * time.Millisecond / 10
}
}
}