chore: add more tests (#3010)

zrpc/resolver/internal/kube/targetparser.go

@@ -1,7 +1,6 @@
 package kube
 
 import (
-	"fmt"
 	"strconv"
 	"strings"
 
@@ -34,10 +33,6 @@ func ParseTarget(target resolver.Target) (Service, error) {
 	endpoints := targets.GetEndpoints(target)
 	if strings.Contains(endpoints, colon) {
 		segs := strings.SplitN(endpoints, colon, 2)
-		if len(segs) < 2 {
-			return emptyService, fmt.Errorf("bad endpoint: %s", endpoints)
-		}
-
 		service.Name = segs[0]
 		port, err := strconv.Atoi(segs[1])
 		if err != nil {

zrpc/resolver/internal/kube/targetparser_test.go

@@ -51,18 +51,24 @@ func TestParseTarget(t *testing.T) {
 			input:  "k8s://ns1/my-svc:800a",
 			hasErr: true,
 		},
+		{
+			name:   "bad endpoint",
+			input:  "k8s://ns1:800/:",
+			hasErr: true,
+		},
 	}
 
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			uri, err := url.Parse(test.input)
-			assert.Nil(t, err)
-			svc, err := ParseTarget(resolver.Target{URL: *uri})
-			if test.hasErr {
-				assert.NotNil(t, err)
-			} else {
-				assert.Nil(t, err)
-				assert.Equal(t, test.expect, svc)
+			if assert.NoError(t, err) {
+				svc, err := ParseTarget(resolver.Target{URL: *uri})
+				if test.hasErr {
+					assert.NotNil(t, err)
+				} else {
+					assert.Nil(t, err)
+					assert.Equal(t, test.expect, svc)
+				}
 			}
 		})
 	}