chore: update unauthorized callback calling order (#1469)

* chore: update unauthorized callback calling order * chore: add comments
2022-01-20 21:09:45 +08:00
parent df0f8ed59e
commit fdc7f64d6f
3 changed files with 9 additions and 4 deletions
--- a/rest/handler/authhandler.go
+++ b/rest/handler/authhandler.go
@@ -113,11 +113,13 @@ func unauthorized(w http.ResponseWriter, r *http.Request, err error, callback Un
 		detailAuthLog(r, noDetailReason)
 	}

-	writer.WriteHeader(http.StatusUnauthorized)
-
+	// let callback go first, to make sure we respond with user-defined HTTP header
 	if callback != nil {
 		callback(writer, r, err)
 	}
+
+	// if user not setting HTTP header, we set header with 401
+	writer.WriteHeader(http.StatusUnauthorized)
 }

 type guardedResponseWriter struct {